Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer temporarily disable redirect in menu #910

Closed
NatoBoram opened this issue Jul 13, 2020 · 3 comments
Closed

Can no longer temporarily disable redirect in menu #910

NatoBoram opened this issue Jul 13, 2020 · 3 comments
Labels
kind/discussion Topical discussion; usually not changes to codebase

Comments

@NatoBoram
Copy link

NatoBoram commented Jul 13, 2020

Describe the bug
A clear and concise description of what the bug is.

It's no longer possible to quickly prevent IPFS-companion from redirecting a public gateway's URL to localhost whilst keeping other interactions.

To Reproduce

Steps to reproduce the behaviour:

  1. Click on IPFS Companion
  2. There's no "Disable direct" anymore.

Expected behavior

A clear and concise description of what you expected to happen.

"Disable redirect" should be there.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Windows 10
  • Firefox
  • ???

Additional context

Add any other context about the problem here.

This is very valuable to troubleshoot custom public gateways. If the extension is now all-or-nothing, then it's completely useless to any public gateway maintainer.

@NatoBoram NatoBoram added the need/triage Needs initial labeling and prioritization label Jul 13, 2020
@jessicaschilling
Copy link
Contributor

Hi @NatoBoram -- Global redirect toggle is no longer in the menu, but is still available in the preferences:
image

@jessicaschilling jessicaschilling removed the need/triage Needs initial labeling and prioritization label Jul 13, 2020
@NatoBoram
Copy link
Author

That doesn't really help. To maintain a public gateway, I need to be able to quickly switch off the redirection and turn it back on when I'm done. Otherwise, I have to turn off the extension completely, but that means I won't be able to test the IPFS API on an IPFS website from my public node.

@lidel
Copy link
Member

lidel commented Jul 13, 2020

@NatoBoram I am often testing resources with and without Companion too, but I use Incognito mode for that, and that is what I suggest in your case too. You can open Incognito mode via browser menu or keyboard shortcut – it is faster than toggling companion via its menu.

Rationale: Companion does more than a simple redirect now (eg. network/http recovery amongst other things) and testing with disabled redirect alone can give you false results in some scenarios. You need to disable Companion to have confidence in testing. IPFS Companion is disabled in Incognito mode, so you don't need to toggle anything to get redirect back, just close Incognito tab.

I hope this helps in speeding up your testing workflow.

Unfortunately having two redirect toggles in main menu proved to be confusing to less technical users, so we are not planning on bringing it back, espcially when Incognito mode is much better for reliable testing.
Hope you understand.

@lidel lidel closed this as completed Jul 13, 2020
@lidel lidel added the kind/discussion Topical discussion; usually not changes to codebase label Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discussion Topical discussion; usually not changes to codebase
Projects
None yet
Development

No branches or pull requests

3 participants