Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't add an IP address to "Always Disable IPFS Integrations" list. #944

Closed
ghost opened this issue Nov 24, 2020 · 5 comments · Fixed by #945
Closed

Can't add an IP address to "Always Disable IPFS Integrations" list. #944

ghost opened this issue Nov 24, 2020 · 5 comments · Fixed by #945
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@ghost
Copy link

ghost commented Nov 24, 2020

I have 2 nodes one of which is hosted on a server I can access over VPN.
Attempting to access the remote gateway results in redirection to 127.0.0.1.
"Always Disable IPFS Integrations" list does not accept IP addresses - after clicking off the field the IP address disappears.

Tested in Firefox and Chromium, the behavior is identical.
@ghost ghost added the need/triage Needs initial labeling and prioritization label Nov 24, 2020
@ipfs ipfs deleted a comment from welcome bot Nov 24, 2020
@jessicaschilling jessicaschilling added exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Nov 24, 2020
@jessicaschilling
Copy link
Contributor

Hey @Sierra410 - Thanks for identifying this use case. We'll prioritize as best we can but in full transparency the team is a bit slammed at the moment. Is this something you'd be interested in PRing?

@ghost
Copy link
Author

ghost commented Nov 24, 2020

I'll take a look, but since I'm unfamiliar with the codebase I might not be able to figure it out.

@ghost
Copy link
Author

ghost commented Nov 24, 2020 •
edited by ghost
Loading

I think I got it, will open a PR soon

@jessicaschilling
Copy link
Contributor

Sweet, thanks!

@ghost ghost mentioned this issue Nov 24, 2020
Merged
@ghost
Copy link
Author

ghost commented Nov 24, 2020

Why are you so mean, GitHub, why are you showing my mistakes to everyone /)c(\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: IP support on opt-in and opt-out lists
1 participant
@jessicaschilling