Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharp (#) in url is not handled elegantly #989

Closed
proletarius101 opened this issue Mar 20, 2021 · 1 comment
Closed

Sharp (#) in url is not handled elegantly #989

proletarius101 opened this issue Mar 20, 2021 · 1 comment
Labels
need/triage Needs initial labeling and prioritization

Comments

@proletarius101
Copy link

proletarius101 commented Mar 20, 2021

Describe the bug
If there's a # in the url (e.g. http://element-web.0x1a8510f2.space.ipns.localhost:8081/#/welcome), it can't be pinned with ipfs companion.

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://element-web.0x1a8510f2.space.ipns.localhost:8081/#/welcome
  2. Click on 'Pin IPFS Recource'
  3. Open ipfs-companion panal again
  4. It shows it's not pinned

Expected behavior
http://element-web.0x1a8510f2.space.ipns.localhost:8081/#/welcome should be pinned as /ipns/element-web.0x1a8510f2.space. That is, it should strip the # suffix, because they are not part of the path in the resource

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Of course,

ipfs pin add /ipns/element-web.0x1a8510f2.space/#/welcome
Error: no link named "#" under QmSmQSREw7PtCNLDC4LxAoi8eWwj3tSCtJGaqXJFjKwA5S

But many sites redirects to a # url automatically. And the ipfs companion's pinning workflow doesn't allow editing.

@proletarius101 proletarius101 added the need/triage Needs initial labeling and prioritization label Mar 20, 2021
@ipfs ipfs deleted a comment from welcome bot Jun 11, 2021
@lidel
Copy link
Member

lidel commented Jun 11, 2021

I believe this is no longer an issue since #810 replaced pinning with import to IPFS.

@lidel lidel closed this as completed Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants