fix: allowing CSP eval to not throw errors #1108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whizzzkid
requested review from
lidel,
meandavejustice and
a team
as code owners
whizzzkid
commented
Nov 24, 2022
| @@ -6,7 +6,7 @@ set -e | |||
| MANIFEST=add-on/manifest.common.json | |||
|
|
|||
| # restore original in case it was modified manually | |||
| test -d .git && git checkout -- $MANIFEST | |||
| # test -d .git && git checkout -- $MANIFEST | |||
There was a problem hiding this comment.
this needs to be a two step process.
|
This will not work with firefox store review process. |
|
only way to remove these warnings is to identify their source in our dependencies, and remove calls to "eval" (either by submitting a PR against dependency, or removing it during the build). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing
unsafe-evalfor firefox