Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all translations upon release #1528

Closed
bertrandfalguiere opened this issue May 27, 2020 · 3 comments
Closed

Update all translations upon release #1528

bertrandfalguiere opened this issue May 27, 2020 · 3 comments
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked
Milestone
v0.13

Comments

@bertrandfalguiere
Copy link
Contributor

  • OS: All
  • Version of IPFS Desktop: At least 0.11.x

Describe the bug
Translations are missing or incomplete in several languages even though they are translated and review on Transifex.

To Reproduce
Steps to reproduce the behavior:

  1. Select French or Italian language (that are fully translated).
  2. See English texts in most places.

Expected behavior
The selected language is displayed onscreen.

I think updating translations from ipld-explorer-components and webUI should be in the check list for releases of IPFS Desktop.

See ipfs/ipld-explorer-components#242 and ipfs/ipfs-webui#1370
@bertrandfalguiere bertrandfalguiere added the need/triage Needs initial labeling and prioritization label May 27, 2020
@bertrandfalguiere bertrandfalguiere changed the title Update all tranlations upon release Update all translations upon release May 27, 2020
@jessicaschilling jessicaschilling added exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels May 27, 2020
@jessicaschilling
Copy link
Contributor

@rafaelramalho19 @lidel just a bump on this as we prepare to release Desktop.

@lidel lidel added this to the v0.13 milestone Sep 14, 2020
@lidel
Copy link
Member

lidel commented Oct 2, 2020 •
edited
Loading

We decoupled Desktop from webui (#1389) and I believe with webui v0.12.2 and 60df053 we should be in a better place when it comes to translations.

@bertrandfalguiere gist: Desktop now gets most of the UI translations with ipfs-webui, so if anything is missing on the latest version at webui.ipfs.io/ then an issue needs to be filled in https://github.com/ipfs-shipyard/ipfs-webui 🙏

@lidel lidel closed this as completed Oct 2, 2020
@lidel
Copy link
Member

lidel commented Oct 3, 2020

..continued in ipfs/ipld-explorer-components#281 🚀

@SgtPooki SgtPooki mentioned this issue May 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked
Projects
None yet
Milestone
v0.13
Development

No branches or pull requests
3 participants
@lidel @jessicaschilling @bertrandfalguiere