Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke-testing IPFS Desktop v0.13.0 #1661

Closed
6 of 8 tasks
lidel opened this issue Oct 2, 2020 · 17 comments
Closed
6 of 8 tasks

Smoke-testing IPFS Desktop v0.13.0 #1661

lidel opened this issue Oct 2, 2020 · 17 comments
Labels
help wanted Seeking public contribution on this issue need/community-input Needs input from the wider community
Milestone

Comments

@lidel
Copy link
Member

lidel commented Oct 2, 2020

We now have new a brand CI/CD pipeline responsible for building IPFS Desktop (#1657, #1659).
Before we ship v0.13, let's have more eyes on platform-specific packages.

Help us by doing a quick test of IPFS Desktop v0.13.0

If you have spare time between now and Monday (~5min):

  1. Install IPFS Desktop using package listed below
  2. Go to Files and Import a folder with some cat pictures
  3. You should be able to see successfully imported files in your Files screen
  4. Comment on this issue with package name and if it went smoothly or if you had any issues.

RC2 build @ f2f34bf

https://bafybeiamxdw3qlecv2mryeojfn46kv32t3nt2a6zajm6wotjadznrtvutm.ipfs.dweb.link/ipfs-desktop-0.13.0-rc2

RC1 build @ 2cfd2f4

Click to expand

macOS

Windows

Linux

If you happen to run Linux, make sure to include the name of distro and Desktop Environment you are running.


office-bat
Our team will be back on Monday,
ready to squash any bugs blocking the release

closes #1153

@lidel lidel added help wanted Seeking public contribution on this issue need/community-input Needs input from the wider community labels Oct 2, 2020
@lidel lidel added this to the v0.13 milestone Oct 2, 2020
@jessicaschilling
Copy link
Contributor

Mac here. All worked as expected for importing both via Import > Folder and just drag/drop, except the drawer gave me an "NaN" while uploading:

image

@bertrandfalguiere
Copy link
Contributor

Tested .deb on Ubuntu 20.04 stock version.

Import button and dragging on Files screen both work as expected, except I got cheese NaNed like @jessicaschilling .
image

(Fur your infurmation, it wasn't a cat picture pur say, so your mileage meow vary.)

@bertrandfalguiere
Copy link
Contributor

bertrandfalguiere commented Oct 3, 2020

Snap: same story
image

Worth noting: My previously addded files and folders are not available.
I think it's because snap sets up its own repository, isolated from other apps...
Also, when dragging, It wrote that I imported 0 items:
image

EDIT: @lidel
I had to install it with snap install --dangerous otherwise I get:
> snap install Downloads/ipfs-desktop-0.13.0-linux-amd64.snap
error: cannot find signatures with metadata for snap "Downloads/ipfs-desktop-0.13.0-linux-amd64.snap"

@olizilla
Copy link
Member

olizilla commented Oct 3, 2020

IPFS-Desktop-0.13.0.dmg - it went smoothly.

  • Importing a directory worked but showed Imported NaN Items as mentioned above, for both import via menu option and import via file drop.

Screenshot 2020-10-03 at 15 31 01

@lidel
Copy link
Member Author

lidel commented Oct 5, 2020

I managed to get hold on Windows 10 laptop and both installing for single user and globally on the OS seems to work as expected. Binary is signed.

@johnnymatthews
Copy link

johnnymatthews commented Oct 5, 2020

Worked fine on Windows 10 (1809). Got a message saying Imported NaN items after adding a file, but apart from that everything was fine.

Capture

@lidel
Copy link
Member Author

lidel commented Oct 5, 2020

Thank you all! 🙏

I've filled ipfs/ipfs-webui#1659 for the NaN thing. It is not related to Electron, but a ux bug in webui (confirmed it in Firefox).

While NaN looks bit awkward, it is shown only when more than one file was imported.
I don't think this small UX nit should block the release that ships go-ipfs 0.7.0 with Ed25519 keys and DHT improvements.

@jessicaschilling Let's discuss this later today during triage

@bertrandfalguiere
Copy link
Contributor

Just tested .AppImage on Ubuntu 20.04

It worked once perfectly with import. Even without the NaN problem:
image

But most of the time there is the NaN/ 0/ 1 problem:
One dragged file:
image

Sometime it displays this :
image
... then this after a few seconds :
image

Other than that it works.

@jessicaschilling
Copy link
Contributor

Update: @Gozala is troubleshooting - ideally we'd patch this before releasing a new Desktop, as it's a highly visible UX flaw even if it's not breaking functionality.

@lidel
Copy link
Member Author

lidel commented Oct 6, 2020

@Gozala fixed theNaN bug (ipfs/ipfs-webui#1660), and we switched to webui v2.11.3 (#1666).

@jessicaschilling @johnnymatthews @bertrandfalguiere @olizilla
please repeat the test using RC2 version 🙏

@jessicaschilling
Copy link
Contributor

jessicaschilling commented Oct 6, 2020

IPFS Desktop-0.13.0.dmg: NaN issue is gone.

Note that I've filed #1668 for less-than-ideal placement of Mac window controls vis-a-vis IPFS cube in the left nav.

@bertrandfalguiere
Copy link
Contributor

AppImage: OK
.deb: OK
.snap: must be installed with the --dangerous flag (I guess it won't be needed once on the snapstore?). Files are in a different place than with other installs, and the peer ID is different. Otherwise, OK

@lidel
Copy link
Member Author

lidel commented Oct 7, 2020

@bertrandfalguiere thank you! Yes, --dangerous won't be needed when it lands on snapstore. Snap has its own philosophy regarding paths, so those discrepancies are expected.

@jessicaschilling Electron had a bunch of security fixes recently (v9.3.1, v9.3.2), so I've updated us to 9.3.2 and created RC3. I've also switched to webui v2.11.4 so #1668 should be fixed on macOS.

Once more, with feeling..

  1. Install IPFS Desktop using package from ipfs-desktop-0.13.0-rc3/
  2. Go to Files and Import a folder with some cat pictures
  3. You should be able to see successfully imported files in your Files screen
  4. Comment on this issue with package name and if it went smoothly or if you had any issues.

Release checklist

@rafaelramalho19
Copy link
Contributor

@lidel tested on MacOS and looks good 👍

@jessicaschilling
Copy link
Contributor

@lidel @rafaelramalho19 Confirmed OK on MacOS here as well.

@lidel
Copy link
Member Author

lidel commented Oct 7, 2020

Thank you all for help! Shipping it to autoupdate channel.

@lidel lidel closed this as completed Oct 7, 2020
@lidel
Copy link
Member Author

lidel commented Oct 7, 2020

v0.13.0 🚢 💨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue need/community-input Needs input from the wider community
Projects
None yet
Development

No branches or pull requests

6 participants