Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix menu → Take screenshot #1663

Closed
3 tasks done
lidel opened this issue Oct 2, 2020 · 1 comment
Closed
3 tasks done

Fix menu → Take screenshot #1663

lidel opened this issue Oct 2, 2020 · 1 comment
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Milestone
v0.13.1

Comments

@lidel
Copy link
Member

lidel commented Oct 2, 2020 •
edited
Loading

Right now a screenshot is taken and added to IPFS and a link is copied to clipboard, but not added to Files.

TODO

  • seems that copied link is broken right now (and uses share.ipfs.io atm)
    • I was testing and copied link was https://share.ipfs.io/#undefined, but that could be due to Electron 10 tests - needs analysis
    • copied link should be https://ipfs.io/ipfs/<cid>?filename=<name-from-mfs>
  • make sure ipfs add is executed with --pin=false
  • add imported file to MFS
    • avoid messy root by adding it to screenshots/YYYY-MM-DD_HH-MM-SS.png ?
@lidel lidel added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up kind/enhancement A net-new feature or improvement to an existing feature good first issue Good issue for new contributors effort/hours Estimated to take one or several hours status/ready Ready to be worked labels Oct 2, 2020
@lidel lidel added this to the v0.14 milestone Oct 2, 2020
@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Oct 2, 2020
@lidel
Copy link
Member Author

lidel commented Oct 12, 2020

Fixed in #1689, released in v0.13.2

@lidel lidel closed this as completed Oct 12, 2020
@lidel lidel modified the milestones: v0.14, v0.13.1 Oct 12, 2020
This was referenced Mar 23, 2021
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 15, 2021
Open
This was referenced Apr 12, 2022
Open
Open
@Kirobi92 Kirobi92 mentioned this issue May 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
v0.13.1
Development

No branches or pull requests
1 participant
@lidel