Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstaller is unable to stop IPFS Desktop #2141

Closed
socketdown opened this issue May 13, 2022 · 3 comments
Closed

Uninstaller is unable to stop IPFS Desktop #2141

socketdown opened this issue May 13, 2022 · 3 comments
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding need/triage Needs initial labeling and prioritization topic/windows Windows specific

Comments

@socketdown
Copy link

socketdown commented May 13, 2022

  • OS: Windows 10
  • Version of IPFS Desktop 0.20.5 (edit: still present in 0.20.6)

Describe the bug
Unable to uninstall IPFS Desktop due to IPFS Desktop still running, but no IPFS process is running.

To Reproduce
Steps to reproduce the behavior:

  1. Try to uninstall IPFS Desktop via Windows Settings
  2. Confirm notification "IPFS Desktop is running, click OK to close"
  3. The uninstaller is unable to close IPFS Desktop

The catch is, that IPFS is not running at all. There is no service nor background process related to IPFS running.

My recommendation is to make the error more detailed, eg. print the name of the offending process.

The next section is more speculation than anything, but I suspect that the uninstaller looks for the phrase "IPFS Desktop" in the currently running processes, while the uninstaller itself uses it in its process name.

@socketdown socketdown added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels May 13, 2022
@ipfs ipfs deleted a comment from welcome bot May 23, 2022
@lidel lidel added help wanted Seeking public contribution on this issue need/analysis Needs further analysis before proceeding topic/windows Windows specific labels May 23, 2022
@lidel
Copy link
Member

lidel commented May 23, 2022

@SgtPooki @hacdias do you have a Windows box to see if this is reproducible?

@hacdias
Copy link
Member

hacdias commented May 26, 2022

Hi @lidel @socketdown

Unfortunately I am not able to reproduce this error. I tried uninstalling IPFS Desktop on Windows with both IPFS Desktop running and not running and both worked successfully. Videos in attachment.

Uninstall.IPFS.Desktop.Running.mov
Uninstall.IPFS.Desktop.Not.Running.mov

@lidel
Copy link
Member

lidel commented Jun 6, 2022

Thank you @hacdias !

We were not able to reproduce on Windows 11, and we have no bandwidth to support older versions of Windows platform.
Please upgrade, if possible. If you experience the same problem on the latest version of Windows, let us know – it could be caused by some third-party software etc.

@lidel lidel closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding need/triage Needs initial labeling and prioritization topic/windows Windows specific
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants