Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling around repo.lock errors #2301

Closed
whizzzkid opened this issue Oct 14, 2022 · 1 comment · Fixed by #2827
Closed

Better error handling around repo.lock errors #2301

whizzzkid opened this issue Oct 14, 2022 · 1 comment · Fixed by #2827
Labels
effort/days Estimated to take multiple days, but less than a week kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@whizzzkid
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Failing to acquire repo.lock errors seem to be common theme in a few issues filed. This can be handled in a better way.

Describe the solution you'd like
A user should not be seeing this error, instead:

  • In the short term, we can have a better error message describing what's the issue and how to fix it.
  • In the longer term, if there exists a daemon instance that holds the lock, we should broker a connection with that that daemon and use that for operation. In case, the daemon does not exist but a lock file has been left behind, we should delete the lock and spin up a new instance

Since this looks like a frequently occurring issue, handling this would in a better way would be great.

@whizzzkid whizzzkid added the need/triage Needs initial labeling and prioritization label Oct 14, 2022
@SgtPooki SgtPooki moved this to To do in IPFS-GUI (PL EngRes) Oct 14, 2022
@SgtPooki
Copy link
Member

  1. investigate existing code to see what could be wrong (lidel indicates that ipfs desktop should have code that handles repo.lock issues)
    • We already prompt users to start IPFS Desktop kubo daemon on different port if we notice that ipfs daemon is already running. If this process fails, we should handle more gracefully

Ultimately, we want to reduce 'repo.lock' errors, while providing users with a quicker solution for unblocking themselves.

@SgtPooki SgtPooki added kind/enhancement A net-new feature or improvement to an existing feature effort/days Estimated to take multiple days, but less than a week status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Jan 16, 2023
@SgtPooki SgtPooki moved this from Needs Grooming to Planned / Backlog in IPFS-GUI (PL EngRes) Jan 16, 2023
@SgtPooki SgtPooki added the P2 Medium: Good to have, but can wait until someone steps up label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to take multiple days, but less than a week kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
No open projects
Status: Planned / Backlog
Development

Successfully merging a pull request may close this issue.

2 participants