Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: No app for link "webui" #2545

Open
RubenKelevra opened this issue Jul 7, 2023 · 2 comments
Open

Windows: No app for link "webui" #2545

RubenKelevra opened this issue Jul 7, 2023 · 2 comments
Labels
area/protocol-handler Issues related to OS-wide protocol handler registered during IPFS Desktop install area/webui Issues specific to interaction with ipfs-webui effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@RubenKelevra
Copy link
Contributor

Describe the bug

I got this popup in the app after clicking on the “Status” button in the left navigation bar.

This does not happen always. It first appeared after the update to 0.21.0, though.

To Reproduce

Steps to reproduce the behavior:

  1. Go to some other page
  2. Click on “Status”
  3. Get popup that Windows can't understand the link webui (probably webui:// is meant with that) and it asks if I wanna search the Windows Store for an App for that.

Expected behavior

Should not appear.

Screenshots

Screenshot 2023-07-07 163745

Additional context

Most of the time I can navigate to the status page fine. But sometimes this appears and is then reproduceable until I navigate a bit somewhere else around in the app.

Couldn't find a real consistent pattern yet when this bug happens.

LOGS

If possible:

  1. From the "IPFS icon" menu in your menubar/system tray, go to AdvancedOpen Logs Directory (for Linux users who do not have this menu, logs can be found in $HOME/.config/IPFS Desktop )
  2. Find *.log files
  3. Attach error.log and combined.log to this issue.

Neither error.log nor combined.log contain anything about this event.

@RubenKelevra RubenKelevra added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Jul 7, 2023
@SgtPooki
Copy link
Member

SgtPooki commented Jul 11, 2023

@RubenKelevra Long time no see! Thanks for reporting this error, I've been wanting to change how we render webui for a while.

It looks like we use a custom protocol handler with electron-serve and LoadUrl to load a url of that handler,

serve({ scheme: 'webui', directory: join(__dirname, '../../assets/webui') })

Instead, we should be using something like serve({ directory: webUiDirectory }) and then passing the webui Window to the returned function similar to filecoin-station/desktop:

https://github.com/filecoin-station/desktop/blob/0cecc2186a2009cdf5d6d55b17fb8a51df64fd57/main/index.js#L117-L119

@SgtPooki SgtPooki added P1 High: Likely tackled by core team if no one steps up area/webui Issues specific to interaction with ipfs-webui area/protocol-handler Issues related to OS-wide protocol handler registered during IPFS Desktop install help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors effort/hours Estimated to take one or several hours status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Jul 11, 2023
@SgtPooki
Copy link
Member

I also think this would fix #762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/protocol-handler Issues related to OS-wide protocol handler registered during IPFS Desktop install area/webui Issues specific to interaction with ipfs-webui effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
No open projects
Status: Prioritized / Ready for Dev
Development

No branches or pull requests

2 participants