Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-destructed on auto-update from v0.6.0 to v0.6.1 #783

Closed
da2x opened this issue Jan 7, 2019 · 10 comments
Closed

Self-destructed on auto-update from v0.6.0 to v0.6.1 #783

da2x opened this issue Jan 7, 2019 · 10 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@da2x
Copy link

da2x commented Jan 7, 2019

I just had v0.6.0 auto-upgrade to v0.6.1. Some unseemly terminal windows popped up on screen and disappeared almost immediately. The resources directory was removed during the update. The app is completely unusable after the update:

internal/modules/cjs/loader.js:604
    throw err;
    ^

Error: Cannot find module 'c:\Program Files\IPFS Desktop\resources\electron.asar\browser\init.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:602:15)
    at Function.Module._load (internal/modules/cjs/loader.js:528:25)
    at Function.Module.runMain (internal/modules/cjs/loader.js:753:10)
    at startup (internal/bootstrap/node.js:241:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:579:3)
@hacdias
Copy link
Member

hacdias commented Jan 7, 2019

@da2x what OS are you using? It would be helpful to know. We're aware that it's working on Windows but not on macOS/Linux.

@da2x
Copy link
Author

da2x commented Jan 7, 2019

This was on Windows 10.

I've not found any installer logs or anything like that. I've left the broken install alone, but there isn't much to say about it other than that the resources directory is missing.

I did get a UAC dialog, and the installer obviously had permission to delete the directory.

@hacdias
Copy link
Member

hacdias commented Jan 7, 2019

That's strange. On my Windows 10 computer I received a notification saying the new version has been downloaded and that it would be installed after quitting the app. Then I closed the app, reopened, and there it was the new version. It didn't even show up any console window.

Did you also receive the notification?

@da2x
Copy link
Author

da2x commented Jan 7, 2019

I didn’t receive any notifications, but I did indeed quit the app when the UAC dialog (unexpectedly, I might add) asked for permission to run an executable. I knew IPFS Desktop had recently added auto-update and I knew a new pre-release was out. I assumed that was what triggered the dialog.

The executable was unsigned so I could have run just about anything.

@hacdias
Copy link
Member

hacdias commented Jan 7, 2019

I didn't even get a UAC dialog (I did a single user install, not machine-wide). Which version were you using before?

@da2x
Copy link
Author

da2x commented Jan 7, 2019

I updated v0.6.0 to v0.6.1, as it says in the title. v0.6.0 was the first and only version installed on this particular system. System-wide installation to c:\Program Files\IPFS Desktop.

@hacdias hacdias added the kind/bug A bug in existing code (including security flaws) label Jan 7, 2019
@hacdias
Copy link
Member

hacdias commented Jan 7, 2019

Oh, maybe it's an issue with system-wide updates... I'll try and look into it

@da2x
Copy link
Author

da2x commented Jan 11, 2019

I just reproduced it on the same system.

  1. Download and run the v0.6.0 installer for Windows
  2. Select install for all users during the installation
  3. Choose to Run IPFS at the end of the installer
  4. Wait until you get an update notification
  5. Open C:\Program Files\IPFS Desktop in File Explorer
  6. Quit IPFS Desktop
  7. Click Okay on the UAC prompt
  8. Watch as every file in C:\Program Files\IPFS Desktop is deleted

I've done this a couple of times now. Every time all files are deleted. I don't know why only some of the files were deleted the first time this happen.

@hacdias
Copy link
Member

hacdias commented Jan 11, 2019

@da2x thanks for the report. Could you also try with the single user installation, please?

@olizilla olizilla mentioned this issue Jan 29, 2019
@hacdias
Copy link
Member

hacdias commented Mar 2, 2019

This issue on Windows won't happen again. I've also removed the system wide installation from the options and it will only be user specific. I've tested on 3 different machines from 3 different people and auto-update is working well. Closing this. If any other issue appears, please let us know ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants