Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peers: crash on /p2p-websocket-star multiaddrs #1287

Closed
lidel opened this issue Oct 31, 2019 · 0 comments · Fixed by #1306
Closed

Peers: crash on /p2p-websocket-star multiaddrs #1287

lidel opened this issue Oct 31, 2019 · 0 comments · Fixed by #1306
Assignees
@hacdias
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@lidel
Copy link
Member

lidel commented Oct 31, 2019

Peers screen in v2.6.0 crashes if one of peers has multiaddr like this:

/dnsaddr/ws-star.discovery.libp2p.io/tcp/443/wss/p2p-websocket-star/ipfs/QmbJbcN3Fvy5bC7Tr95STx5VFiP1G1WLPCHNceh1yShfbb
/dns4/ws-star.discovery.libp2p.io/tcp/443/wss/p2p-websocket-star/ipfs/QmYy3ka6HsQzpdTXY63nUKShsVdgg5zdhMXZXFeNGPyMT4

We usually don't see those multiaddrs, but we have them whn running embedded js-ipfs in Brave (ipfs/ipfs-companion#716):

2019-10-31-122541_1886x1006_scrot
@lidel lidel added kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP labels Oct 31, 2019
@lidel lidel mentioned this issue Oct 31, 2019
Closed
@hacdias hacdias mentioned this issue Nov 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: peers page with /p2p-websocket-star addrs ipfs/ipfs-webui
2 participants
@lidel @hacdias