Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files screen content only semi-functional with a screen reader #1498

Closed
marrie opened this issue May 23, 2020 · 9 comments · Fixed by #1512
Closed

Files screen content only semi-functional with a screen reader #1498

marrie opened this issue May 23, 2020 · 9 comments · Fixed by #1512
Assignees
Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@marrie
Copy link

marrie commented May 23, 2020

Describe the bug
A clear and concise description of what the bug is.

I'm visually impaired, so need to access the destkop app with a screenreader called voiceover in the case of mac os. You will need to hit command plus f5 to access voiceover from anywhere.
To Reproduce
Steps to reproduce the behavior:

  1. launch voiceover
  2. launch the ipfs app
  3. click the status menu, or what they I think call the extras menu, the thign where all the icons for dropbox and yoru time are.
  4. click files
  5. try and use voiceover only to access the files area. . do not use a moniter.
    Expected behavior
    A clear and concise description of what you expected to happen.
    I should be able to navigate all controls using the curser and arrow keys.
    Screenshots
    If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

mac os 10.15 ips Revision 1b58b62
Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
If you need a demo of how voiceover works, please let me know.

@marrie marrie added the need/triage Needs initial labeling and prioritization label May 23, 2020
@autonome
Copy link

Thanks for reporting @marrie! @rafaelramalho19 and @jessicaschilling will look at this, but Monday is a holiday in US so possibly not until Tues.

@marrie
Copy link
Author

marrie commented May 23, 2020 via email

@jessicaschilling
Copy link
Contributor

jessicaschilling commented May 23, 2020

@rafaelramalho19 — can you please take a look at this when you are back? I’m afraid that this is outside my area of expertise. Thank you!

@rafaelramalho19
Copy link
Contributor

Yes, I love fixing accessibility issues 😄

Thanks for reporting this @marrie, I will look at this soon.

@jessicaschilling jessicaschilling added exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP and removed need/triage Needs initial labeling and prioritization labels May 26, 2020
@jessicaschilling jessicaschilling changed the title files area is half way usablre with a screen reader Files screen content only semi-functional with a screen reader May 28, 2020
@rafaelramalho19
Copy link
Contributor

@marrie Thank you once again for reporting this.

I've gone ahead and created a pull request to fix this. I would very much appreciate your input in this if that's possible!

@marrie
Copy link
Author

marrie commented Jun 2, 2020 via email

@rafaelramalho19
Copy link
Contributor

@marrie this should be in the next release of ipfs-desktop, so if you could wait for that and then provide feedback to us, it would be awesome!

You're always welcome to open issues with problems you may encounter with ipfs-desktop and webui, as it's really valuable for us the input of someone who uses screen readers daily.

If you're really eager to test this out, we can also create a demo instance of webui with these changes 😄

@marrie
Copy link
Author

marrie commented Jun 3, 2020 via email

@rafaelramalho19
Copy link
Contributor

That's awesome! Thank you so much @marrie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants