Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPNS and DNSLink fail to load in the explore tab #1884

Closed
Tracked by #113
aschmahmann opened this issue Jan 7, 2022 · 3 comments
Closed
Tracked by #113

IPNS and DNSLink fail to load in the explore tab #1884

aschmahmann opened this issue Jan 7, 2022 · 3 comments
Labels
area/screen/explore Issues related to IPLS Explorer screen effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up starmaps

Comments

@aschmahmann
Copy link

Describe the bug
When typing things like /ipns/k51..., /ipns/ipfs.io into the browse/inspect bar if you hit inspect it'll take you to the explore page and will error.

This bug might be related to explore.ipld.io more than here, but since we depend on similar components I'm filing here. Feel free to move or redirect.

There are a variety of errors depending on the mutable identifier type:

  • /ipns/k51... -> Error: No resolver found for codec "libp2p-key"
  • /ipns/12D3... -> HTTPError: invalid path "12D3K...": selected encoding not supported
  • /ipns/Qm... -> Seems to hang/break things (but could be mistaken)
  • /ipns/ipfs.io -> Error: invalid character '.' in 'ipfs.io'

To Reproduce
Steps to reproduce the behavior:

  1. Go to Status Page
  2. Click on Browse bar
  3. Type in one of the paths above and click the Inspect button
  4. See error

Expected behavior
IPNS resolution should work (i.e. resolve the IPNS path to the IPFS path and continue as normal). Alternatively some error like "IPNS not supported" would work and turn the rest of this into a feature request.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windowsd 10
  • Browser: Chrome
  • Version 96
@aschmahmann aschmahmann added the need/triage Needs initial labeling and prioritization label Jan 7, 2022
@ipfs ipfs deleted a comment from welcome bot Jan 14, 2022
@lidel
Copy link
Member

lidel commented Jan 14, 2022

This is a sensible enhancement.

  • At the very minimum, anything other than CID or /ipfs/CID/... should get resolved to an immutable content path before being passed to IPLD Explorer component

Currently, it errors:

2022-08-01_22-05

Note: /ipns/en.wikipedia-on-ipfs.org/wiki/ is a HAMT-sharded unixfs dir

If anyone wants to work on this, open PR in https://github.com/ipfs/ipld-explorer-components and ping @lidel for review/guidance.

@lidel lidel added area/screen/explore Issues related to IPLS Explorer screen P2 Medium: Good to have, but can wait until someone steps up exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature effort/hours Estimated to take one or several hours help wanted Seeking public contribution on this issue and removed need/triage Needs initial labeling and prioritization labels Jan 14, 2022
@SgtPooki
Copy link
Member

related: #1076

@SgtPooki
Copy link
Member

closing in favor of ipfs/ipld-explorer-components#400

@SgtPooki SgtPooki closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/explore Issues related to IPLS Explorer screen effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up starmaps
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants