Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: new e2e tests for explore page are failing in kubo CI #2108

Closed
SgtPooki opened this issue Mar 20, 2023 · 0 comments · Fixed by #2109
Closed

bug: new e2e tests for explore page are failing in kubo CI #2108

SgtPooki opened this issue Mar 20, 2023 · 0 comments · Fixed by #2109
Assignees
@SgtPooki
Labels
area/screen/explore Issues related to IPLS Explorer screen effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP topic/ci Continuous integration

Comments

@SgtPooki
Copy link
Member

Describe the bug

Perhaps Kubo CI fails because these new tests don't use static CAR fixtures for inspected DAGs , and load content from the network instead. Could be that we have more expensive CI and we run out of "allowed network WAN connection pool" or something?

If [the network] is the underlying reason, potential fix is to fill issue in https://github.com/ipfs/ipfs-webui/issues/ and ping #ipfs-gui-dev to fix E2E tests in ipfs-webui so they work in offline mode (e.g. ipfs block get related CIDs, store them in some directory, and ipfs block put them before running E2E tests) so tests don't timeout when run on slow/throttled CI

To Reproduce

Run e2e tests without network connection

Expected behavior
Tests run fine in offline mode

Additional context

related to merge of #2098

failling CI test: https://app.circleci.com/pipelines/github/ipfs/kubo/9385/workflows/dfd6c3bb-f2d0-4cb1-9b06-f7a21d528d42/jobs/101478

slack thread: https://filecoinproject.slack.com/archives/C04M8232QRW/p1678995491361729

related to followup from PR 2098: #2106
@SgtPooki SgtPooki added need/triage Needs initial labeling and prioritization kind/bug A bug in existing code (including security flaws) exp/intermediate Prior experience is likely helpful P0 Critical: Tackled by core team ASAP effort/days Estimated to take multiple days, but less than a week area/screen/explore Issues related to IPLS Explorer screen topic/ci Continuous integration labels Mar 20, 2023
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Mar 20, 2023
@SgtPooki SgtPooki moved this from Needs Grooming to Prioritized / Ready for Dev in IPFS-GUI (PL EngRes) Mar 20, 2023
@SgtPooki SgtPooki linked a pull request Mar 21, 2023 that will close this issue
fix: e2e/explore.test.js succeeds in offline mode #2109
Merged
@SgtPooki SgtPooki mentioned this issue Mar 21, 2023
Merged
@whizzzkid whizzzkid removed the need/triage Needs initial labeling and prioritization label Mar 22, 2023
@whizzzkid whizzzkid moved this from Prioritized / Ready for Dev to In Progress in IPFS-GUI (PL EngRes) Mar 22, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in IPFS-GUI (PL EngRes) Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
area/screen/explore Issues related to IPLS Explorer screen effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP topic/ci Continuous integration
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: e2e/explore.test.js succeeds in offline mode ipfs/ipfs-webui
2 participants
@SgtPooki @whizzzkid