Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/webrtc-direct listener breaks Status page #2176

Closed
lidel opened this issue Nov 9, 2023 · 1 comment · Fixed by #2180
Closed

/webrtc-direct listener breaks Status page #2176

lidel opened this issue Nov 9, 2023 · 1 comment · Fixed by #2180
Assignees
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Nov 9, 2023

Describe the bug

This is the same problems as #2033 but for /webrtc-direct

To Reproduce

  1. Run Kubo v0.24.0
  2. Enable WebRTCDirect by
    1. adding "/ip4/0.0.0.0/udp/4002/webrtc-direct" to Addresses.Swarm
    2. enabling transport via ipfs config Swarm.Transports.Network.WebRTCDirect --json true
  3. Restart node, wait a minute for listeners to set up via UPnP
  4. Open webui
  5. See broken state:

    2023-11-09_03-30

See Release Notes for more info: https://github.com/ipfs/kubo/blob/master/docs/changelogs/v0.24.md

Expected behavior

Show /webrtc-direct (spec) listeners returned by ipfs.id
While at it, also make sure /webrtc (spec) is supported as well (not in kubo yet, but will be added in near future).

To avoid a big refactor, a fix similar to patches/multiaddr+8.1.2.patch from #2057 would be sufficient for solving the problem at hand.
Add codes for webrtc-direct and webrtc https://github.com/multiformats/multiaddr/blob/master/protocols.csv

@lidel lidel added kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up need/triage Needs initial labeling and prioritization labels Nov 9, 2023
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Nov 9, 2023
@lidel lidel mentioned this issue Nov 24, 2023
9 tasks
@SgtPooki SgtPooki self-assigned this Nov 28, 2023
@lidel
Copy link
Member Author

lidel commented Nov 28, 2023

Better repro steps:

$ # shut down local node (if you have it)
$ go install github.com/ipfs/kubo/cmd/ipfs@v0.24.0 # use latest binary
$ export IPFS_PATH=/tmp/test-webrtc # use empty profile
$ ipfs init 
...
initializing IPFS node at /tmp/test-webrtc
$ ipfs config Swarm.Transports.Network.WebRTCDirect --json true
$ ipfs config Addresses.Swarm --json '["/ip4/0.0.0.0/udp/4002/webrtc-direct"]'
$ ipfs daemon
...
WebUI: http://127.0.0.1:5001/webui

Opening WebUI at http://127.0.0.1:5001/webui should produce screenshot I described, clicking on Advanced will reveal empty addresses:

2023-11-28_21-36
2023-11-28_21-36_1

@SgtPooki SgtPooki linked a pull request Nov 30, 2023 that will close this issue
1 task
@whizzzkid whizzzkid added exp/expert Having worked on the specific codebase is important effort/days Estimated to take multiple days, but less than a week and removed need/triage Needs initial labeling and prioritization labels Nov 30, 2023
@github-project-automation github-project-automation bot moved this from Needs Grooming to Done in IPFS-GUI (PL EngRes) Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants