Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Bundle Size #255

Closed
dignifiedquire opened this issue Feb 23, 2016 · 9 comments
Closed

Improve Bundle Size #255

dignifiedquire opened this issue Feb 23, 2016 · 9 comments
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue

Comments

@dignifiedquire
Copy link
Member

Webpack@2 adds tree shaking so we should be able to reduce our overall bundle size with it. In addition we should switch to using lodash-es as we are using es 2015 modules and webpack@2 can then take advantage of this.

@dignifiedquire dignifiedquire added help wanted Seeking public contribution on this issue exp/intermediate Prior experience is likely helpful build labels Feb 23, 2016
@mcmunder
Copy link

Preact might be worth considering?!

@dignifiedquire
Copy link
Member Author

Definitely

@mcmunder
Copy link

I could give it a try next week!? Let's see if I get it to run so I can measure the effects on bundle size etc... What would be the official procedure?

@dignifiedquire
Copy link
Member Author

try it out, post your findings and make a pr :)

@dignifiedquire
Copy link
Member Author

hey @mcmunder did you get to try it out? I have been using preact in a new project and it is really nice

@mcmunder
Copy link

@dignifiedquire unfortunately I didn't find the time so far ;-( Too much work! But it's high up on my want to do list!

@tadeaspetak
Copy link

tadeaspetak commented Sep 29, 2017

Regarding the initial comment: As far as I can see, webpack@3 is now used in the master and so is lodash-es. Are there any other library updates that should be done right now?

I would like to start contributing to the project. @mcmunder @dignifiedquire Should I look into using preact? Does anyone have any experience with inferno? It claims to be 1,5x faster than Preact even (about 5x faster than React).

@mcmunder
Copy link

mcmunder commented Oct 2, 2017

@tadeaspetak unfortunately I did not find any time to look into this - despite my enthusiastic earlier comments... So from my side: go ahead! I don't have any experience with inferno but it looks very promising indeed!

@daviddias daviddias removed the build label Mar 17, 2018
@olizilla
Copy link
Member

Web UI v2 is uses the create-react-app tooling which includes webpack with all the tree-shaking and bundle splitting fancies. We've enabled https://github.com/siddharthkp/bundlesize checks on CI so we get warnings when we bloat up, and we check new deps on https://bundlephobia.com/ beforehand.

I'm not a massive CRA fan but it has worked well for us and we wanted to make sure that we run into any issues building an IPFS app on it before we get dozens more i issues about it when it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue
Projects
None yet
Development

No branches or pull requests

5 participants