Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display help when pressing '?' #756

Closed
hacdias opened this issue Aug 20, 2018 · 8 comments
Closed

Display help when pressing '?' #756

hacdias opened this issue Aug 20, 2018 · 8 comments
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design

Comments

@hacdias
Copy link
Member

hacdias commented Aug 20, 2018

Current shortcuts:

  • ESC - Unselect everything.
  • F2 - Rename selected.
  • Del - Delete selected.
  • Enter or Meta+Arrow Right - Open selected.
  • Arrow up/down - Focus files.

/cc @lidel

@olizilla
Copy link
Member

What help are you thinking of here? A list of keyboard commands?

@lidel
Copy link
Member

lidel commented Sep 28, 2018

@olizilla Yes, supported keyboard shortcuts.
My idea was to do something similar to pressing ? in Gmail, but less ugly ✨
(we could also add there a note about IPFS Docs at http://docs.ipfs.io)

@lidel
Copy link
Member

lidel commented Dec 19, 2018

I wonder if we could support moving to menu navigation via left/right arrows.
Right now if I want to open Files screen I need to use mouse, would be super useful to switch between screens with keyboard alone.

cc @terichadbourne https://github.com/protocol/design/issues/145

@lidel lidel changed the title Files Browser: should help when clicking '?' Display help when pressing '?' Dec 19, 2018
@terichadbourne
Copy link

I love the focus on keyboard users here.

In general, I presume that sticking to the common methods they use (for example, tab to focus on the next thing on the site and enter to select it) will be better than creating new site-specific shortcuts, but I'm not clear on what part of the site interaction you're referring to, so feel free to ignore this comment if it's irrelevant.

@lidel
Copy link
Member

lidel commented Dec 19, 2018

To illustrate:

2018-12-20--00-16-01

  • What works right now is the pink arrow on the right – user can navigate between files using up/down arrows.

  • What we are missing is a way to switch to and from left menu (greens) and move between screens (left pink arrow).

    • I tested pressing Tab and Tab+Shift and it seems to work, but it acts as a global iterator and gets confused on some screens such as Files (where selection disappears the moment it enters the file list). Perhaps all we need to do here is to polish use of Tab, to ensure it works everywhere?

@ericronne
Copy link

Do we have any accessibility gurus? I'm not one, but i know that tabbing is core to the way keyboard-based users get around, so that's also a consideration.

@terichadbourne
Copy link

My accessibility training is minimal, but what I would have expected on a page like this with left-side nav is that when you tabbed from the top of the page you would first cycle through all of the nav options (where then clicking or hitting enter would change the content on the right) and then cycle through all of the clickable content on the right side of the page (main content). I don't think it's necessary to build a special command to tab from left to right. Just think of nav as top in the cycling, and make sure it's in nav tags so people with various accessibility tools can skip it or access it in the ways they're used to.

@jessicaschilling jessicaschilling added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design and removed to do labels Mar 30, 2020
@jessicaschilling
Copy link
Contributor

Closing in favor of accessibility master issue ipfs/ipfs-gui#28 -- this discussion has been linked to from there so we avoid it getting lost to history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design
Projects
None yet
Development

No branches or pull requests

6 participants