Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files list slow to render when directory contains many files #856

Open
1 task
Tracked by #113
olizilla opened this issue Oct 13, 2018 · 2 comments
Open
1 task
Tracked by #113

Files list slow to render when directory contains many files #856

olizilla opened this issue Oct 13, 2018 · 2 comments
Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@olizilla
Copy link
Member

We're need to paginate the rendering of large directories. We're using react-virtualized for the peers list and the links list in the ipld-explorer, so it'd make sense to use that here.

To deal with really large directories of things, we'd also need to be able to request paginated chunks of a dir listing from the api.

We did it good if...

  • Files page can render the (first few) files list for a directory containing > 1000 files in < 1s
@olizilla olizilla added kind/bug A bug in existing code (including security flaws) exp/intermediate Prior experience is likely helpful P1 High: Likely tackled by core team if no one steps up labels Oct 13, 2018
@hacdias
Copy link
Member

hacdias commented Oct 19, 2018

I can only find an issue with requesting paginated chunks from the API: it must also support sorting otherwise the user experience will be a mess.

@olizilla olizilla mentioned this issue Jan 7, 2019
10 tasks
@JiaJiaJiang
Copy link

JiaJiaJiang commented Mar 20, 2019

It's still slow if the webui is hosting on a remote server.
May the file list load the stat of files in parallel using Promise.all() instead of one by one? Or just lazy load the CumulativeSize of them because the size is sometimes not the most important thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

3 participants