Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Help improve this app by sending anonymous usage data." is not remembered and reappears on CTRL + F5 #998

Closed
Mikaela opened this issue Apr 1, 2019 · 4 comments

Comments

@Mikaela
Copy link

Mikaela commented Apr 1, 2019

Describe the bug

The question "Help improve this app by sending anonymous usage data." appears every time I press CTRL+F5. I am not sure if this is the correct repository (but GitHub suggesting related issue #774 hints this is), I am using IPFS Companion.

To Reproduce
Steps to reproduce the behavior:

  1. Go to IPFS webui (for me http://[::1]:8082/ipfs/QmfQkD8pBSBCBxWEwFSu4XaDVSWK6bjnNuaWZjMyQbyDub/#/ )
  2. There is a question "Help improve this app by sending anonymous usage data.", press OK or go to "More info" and give the permission.
  3. Return to the index and/or press CTRL + F5
  4. See the question return. This also happens by itself at times when revisiting the webui, but CTRL + F5 seems the easiest way to reproduce it.

Expected behavior

I see the prompt to share anonymous usage data only once.

Screenshots

I think it's N/A, but please feel free to ask.

Desktop (please complete the following information):

  • OS: Debian testing (Buster/10)
  • Browser: Firefox
  • Version: 67.0b6 (20190328152334)

Additional context

I have Cookie Autodelete, but [::1] is whitelisted, so I don't think it should affect here. I have moved to [::1] from 127.0.0.1 by myself (see also ipfs/kubo#5905). I am running Syncthing on 8080, so I have changed the IPFS port.

@olizilla
Copy link
Member

olizilla commented Apr 2, 2019

Oh interesting! Web UI is currently using the browers IndexDB to keep a record of the list of consents that the user grants. I took a quick look at Cookie Autodelete but I don't see any references to it cleaning IndexDB records... do you know if anything in your set up might be deleting that? For reference, in Firefox I see the following entry in the inspector > Storage > Index DB > bundle-cache > bundle-cache

Screenshot 2019-04-02 at 11 43 30

If something is deleting that DB then that would explain why the ask keeps showing up, as we dont track anything if we find no record of user consent.

@Mikaela
Copy link
Author

Mikaela commented Apr 2, 2019

I seem to have localstorage cleaning enabled in Cookie Autodelete, but it shouldn't affect as ::1 is in whitelist and I cannot find the analytics key, bundle-cache seems to be empty.

When I go to https://webui.ipfs.io/ and click the OK, I see analytics getting created. My CAD whitelist also has *.ipfs.io.

@bertrandfalguiere
Copy link
Contributor

Looks fixed?

@jessicaschilling
Copy link
Contributor

jessicaschilling commented Sep 21, 2020

@Mikaela - closing this issue. Please comment to re-open if you have further problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants