Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ipld-dag-pb with @ipld/dag-pb #329

Closed
Tracked by #1965 ...
SgtPooki opened this issue Jul 8, 2022 · 4 comments · Fixed by #330
Closed
Tracked by #1965 ...

Replace ipld-dag-pb with @ipld/dag-pb #329

SgtPooki opened this issue Jul 8, 2022 · 4 comments · Fixed by #330
Assignees
Labels
exp/expert Having worked on the specific codebase is important need/maintainers-input Needs input from the current maintainer(s) P1 High: Likely tackled by core team if no one steps up released status/in-progress In progress

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Jul 8, 2022

"ipld-dag-pb": "0.22.2",

Required for ipfs/ipfs-webui#1840

@welcome
Copy link

welcome bot commented Jul 8, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@SgtPooki
Copy link
Member Author

SgtPooki commented Jul 8, 2022

@SgtPooki
Copy link
Member Author

SgtPooki commented Jul 8, 2022

some dependencies aren't being loaded properly..?

    ReferenceError: TextDecoder is not defined

       5 | import * as Block from 'multiformats/block'
       6 | import { sha256 as hasher } from 'multiformats/hashes/sha2'
    >  7 | import * as codec from '@ipld/dag-pb'
         | ^
       8 |
       9 | import resolveIpldPath, { findLinkPath } from './resolve-ipld-path'
      10 |

      at Object.<anonymous> (node_modules/@ipld/dag-pb/cjs/src/pb-decode.js:5:21)
      at Object.<anonymous> (node_modules/@ipld/dag-pb/cjs/src/index.js:6:16)
      at Object.<anonymous> (src/lib/resolve-ipld-path.test.js:7:1)

@SgtPooki SgtPooki linked a pull request Jul 9, 2022 that will close this issue
@SgtPooki SgtPooki added status/in-progress In progress exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up need/maintainers-input Needs input from the current maintainer(s) labels Aug 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/expert Having worked on the specific codebase is important need/maintainers-input Needs input from the current maintainer(s) P1 High: Likely tackled by core team if no one steps up released status/in-progress In progress
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant