Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow explore state to be updated outside of hashchange events #457

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Oct 30, 2024

fix: allow explore state to be updated outside of hashchange events

This change allows the explore state to be updated outside of hashchange events. This is useful for cases where:

  1. The explore state is updated by a component that is not part of the explore view.
  2. The router used by the consuming app does not emit hashchange events.

Fixes #455

@SgtPooki SgtPooki requested a review from a team as a code owner October 30, 2024 22:21
@SgtPooki SgtPooki linked an issue Oct 30, 2024 that may be closed by this pull request
3 tasks
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@SgtPooki SgtPooki merged commit 6299b86 into master Oct 30, 2024
16 checks passed
@SgtPooki SgtPooki deleted the 455-fix-remove-dependency-on-hashchange-event branch October 30, 2024 23:06
github-actions bot pushed a commit that referenced this pull request Oct 30, 2024
## [8.0.3](v8.0.2...v8.0.3) (2024-10-30)

### Bug Fixes

* allow explore state to be updated ([#457](#457)) ([6299b86](6299b86))
Copy link
Contributor

🎉 This PR is included in version 8.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: remove dependency on hashchange event
1 participant