feat: introduce ipld car explorer form #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
lidel
previously requested changes
Apr 12, 2022
There was a problem hiding this comment.
Thank you for picking this up! 👍
Main ask is to fix tests:
https://app.circleci.com/pipelines/github/ipfs/ipld-explorer-components/563/workflows/9745fe0a-8d77-445a-97a3-a60aae627a6c/jobs/748
Smaller asks inline below.
alvin-reyes
dismissed
lidel’s stale review
all changes that was requested is now available on the latest commit.
lidel
force-pushed
the
feat/car-explorer
branch
from
72b9c85 to
d3ba70c
Compare
lidel
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Looks good as a MVP:
- does not impact ipfs-webui, should be fine to merge
- UI of having to click three times (CAR→Select File → Explore) is bit weird, clicking on CAR once should be enough to select file + open correct CID after import, but we can refine it in follow-up PRs if needed
- circleci error can be ignored – i disabled it on this repo and moved to github actions
I'm merging this to test auto-release added in #314
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
## [2.1.0](v2.0.4...v2.1.0) (2022-04-13) ### Features * introduce ipld car explorer form ([#313](#313)) ([c89e6ca](c89e6ca)) ### Trivial Changes * add auto-release ([#314](#314)) ([0c5551a](0c5551a)) * fix community CONTRIBUTING.md links ([#305](#305)) ([37cdc9d](37cdc9d)) * **release:** add missing dep ([a085848](a085848))
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
## [2.1.0](v2.0.4...v2.1.0) (2022-04-13) ### Features * introduce ipld car explorer form ([#313](#313)) ([c89e6ca](c89e6ca)) ### Trivial Changes * add auto-release ([#314](#314)) ([0c5551a](0c5551a)) * fix community CONTRIBUTING.md links ([#305](#305)) ([37cdc9d](37cdc9d)) * **release:** add missing dep ([a085848](a085848))
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
## [2.1.0](v2.0.4...v2.1.0) (2022-04-13) ### Features * introduce ipld car explorer form ([#313](#313)) ([c89e6ca](c89e6ca)) ### Trivial Changes * add auto-release ([#314](#314)) ([0c5551a](0c5551a)) * fix community CONTRIBUTING.md links ([#305](#305)) ([37cdc9d](37cdc9d)) * **release:** add missing dep ([a085848](a085848))
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
## [2.1.0](v2.0.4...v2.1.0) (2022-04-13) ### Features * introduce ipld car explorer form ([#313](#313)) ([c89e6ca](c89e6ca)) ### Trivial Changes * add auto-release ([#314](#314)) ([0c5551a](0c5551a)) * fix community CONTRIBUTING.md links ([#305](#305)) ([37cdc9d](37cdc9d)) * **release:** add missing dep ([a085848](a085848))
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
## [2.1.0](v2.0.4...v2.1.0) (2022-04-13) ### Features * introduce ipld car explorer form ([#313](#313)) ([c89e6ca](c89e6ca)) ### Trivial Changes * add auto-release ([#314](#314)) ([0c5551a](0c5551a)) * fix community CONTRIBUTING.md links ([#305](#305)) ([37cdc9d](37cdc9d)) * **release:** add missing dep ([e58faaa](e58faaa))
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change introduces a new form to import CAR file, grab the root CID and use the current engine to show the links on the IPLD explorer. This change is a pre-cursor to the new code change on ipld explorer and on webui
Related
https://github.com/ipfs/ipfs-webui
https://github.com/ipld/explore.ipld.io
Verification
Tested using ipld.explorer.
Note CAR and CID buttons will be different. These buttons will be modified on the ipld.explorer PR.
Load new CAR file
Multihash details and graph