This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
pass the config protocol to http requests #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: noah the goodra <peterpan0413@live.com>
ghost
removed
the
|
Thank you @jfmherokiller :) |
|
has this change been pushed out to npm/unpkg yet? |
|
@jfmherokiller yep, should be there since 14.3.6 -> https://github.com/ipfs/js-ipfs-api/commits/master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While calling
request(config.protocol)sets the right http protocol api to use it does not correctly pass the protocol information to node_modules/stream-http.If the page is loaded over https and the daemon is located on http it fails to send the api request to the deamon.
This is because the code believes the daemon is located at https://127.0.0.1:5001/ when it is actually located at http://127.0.0.1:5001/.
Without this change the code throws an unrecoverable error and doesnt provide the user with information to fix the issue, with the change it still throws an error but it also lets the user resolve the issue by clicking the mixed content shield
and allowing insecure content.