Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

feat: support key/export and key/import #653

Merged
merged 3 commits into from
Dec 28, 2017
Merged

feat: support key/export and key/import #653

merged 3 commits into from
Dec 28, 2017

Conversation

richardschneider
Copy link
Contributor

Needs to update dependency on PR ipfs-inactive/interface-js-ipfs-core#187

@richardschneider
Copy link
Contributor Author

@diasdavid Two tests are failing in .miscellaneous. This has nothing to do with my changes.

.miscellaneous
       "before all" hook:
     Error: Uncaught AssertionError: expected 'timeout' to not exist (test/interface/generic.spec.js:27486)

  2) .miscellaneous
       "after all" hook:
     Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

@codecov
Copy link

codecov bot commented Dec 28, 2017

Codecov Report

Merging #653 into master will decrease coverage by 0.13%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #653      +/-   ##
=========================================
- Coverage   84.54%   84.4%   -0.14%     
=========================================
  Files         122     124       +2     
  Lines        1786    1796      +10     
=========================================
+ Hits         1510    1516       +6     
- Misses        276     280       +4
Impacted Files Coverage Δ
src/key/index.js 100% <ø> (ø) ⬆️
src/key/export.js 50% <50%> (ø)
src/key/import.js 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0eaa78...abcde31. Read the comment docs.

@ghost ghost assigned daviddias Dec 28, 2017
@daviddias daviddias merged commit 496f08e into master Dec 28, 2017
@daviddias daviddias deleted the keyx branch December 28, 2017 08:41
@ghost ghost removed the in progress label Dec 28, 2017
dryajov pushed a commit that referenced this pull request Jan 3, 2018
* feat: support key/export and key/import

* chore: update deps

* chore
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants