This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: res.req only in Node.js, in browser use res.url instead #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
ghost
assigned 
achingbrain
reviewed
Jun 29, 2018
| if (isNode) { | ||
| log(res.req.method, `${res.req.getHeaders().host}${res.req.path}`, res.statusCode, res.statusMessage) | ||
| } else { | ||
| log(res.url, res.statusCode, res.statusMessage) |
There was a problem hiding this comment.
Is the method available or just the URL?
There was a problem hiding this comment.
I looked but did not see the method
There was a problem hiding this comment.
It's all POST anyway..
achingbrain
approved these changes
Jun 29, 2018
|
Ok so tests are still failing but for other reasons, they got a whole lot further than they did last time (for the ones that actually got started). |
|
@alanshaw @achingbrain When I run last version of ipfs-api inside Electron, |
|
Thanks @requilence - I've created an issue to track this #807 - would you be willing to send a PR to fix this? |
danieldaf
pushed a commit
to danieldaf/js-ipfs-api
that referenced
this pull request
Jul 21, 2018
…active#798) License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.