Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance tests: define a baseline #173

Open
pgte opened this issue Apr 16, 2018 · 4 comments
Open

performance tests: define a baseline #173

pgte opened this issue Apr 16, 2018 · 4 comments
Labels
status/ready Ready to be worked

Comments

@pgte
Copy link
Contributor

pgte commented Apr 16, 2018

I think we should define some performance requirements for bitswap (like, for example: "for 10 bitswaps exchanging 1000 blocks between themselves, they must execute this in X seconds or less"), and then apply these to the already existing test/benchmarks.

This is almost done (test/benchmarks already can be parametrised to spawn a network of x nodes exchanging y blocks), so I think this is just a matter of defining the baseline to:

a) prevent performance regressions
b) incorporate improvements

@victorbjelkholm @vmx Thoughts on this?

@victorb
Copy link
Member

victorb commented Apr 17, 2018

Sounds about right. One thing that is needed for the baseline is the specs of the machine where the benchmarks are run, so we can still ~ follow the baseline on less/more powerful machines.

@pgte
Copy link
Contributor Author

pgte commented Apr 17, 2018

@victorbjelkholm Should the new CI infra-structure be able to handle this stability, or are we looking into some variance we need to deal with?

@victorb
Copy link
Member

victorb commented Apr 17, 2018

My thinking is that we should probably use some standard specs from an average laptop as the baseline, and we can spin up CI workers that are close to that.

@vmx
Copy link
Member

vmx commented Apr 17, 2018

Sounds good. Couchbase has a nice dashboard to easily spot regressions between builds: http://showfast.sc.couchbase.com/. Having something like that would be great. I know that's a separate discussion, but I thought this is a good place to bring it up.

@daviddias daviddias added the status/ready Ready to be worked label May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

4 participants