Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is there a refcounter for PeerHandler in the WantManager? #87

Closed
daviddias opened this issue Dec 21, 2016 · 3 comments
Closed

Why is there a refcounter for PeerHandler in the WantManager? #87

daviddias opened this issue Dec 21, 2016 · 3 comments
Assignees
@dignifiedquire
Labels
kind/support A question or request for support P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@daviddias
Copy link
Member

I've asked this in this issue #76

@dignifiedquire ?
@daviddias daviddias added the kind/support A question or request for support label Dec 21, 2016
@daviddias daviddias mentioned this issue Dec 21, 2016
Closed
15 tasks
@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Dec 22, 2016
@daviddias
Copy link
Member Author

Ping :)

@daviddias daviddias added status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up and removed status/deferred Conscious decision to pause or backlog labels Oct 17, 2017
@daviddias
Copy link
Member Author

@dignifiedquire please brain dump 🙏🏽

@dignifiedquire
Copy link
Member

To handle this: https://github.com/ipfs/js-ipfs-bitswap/blob/master/src/want-manager/index.js#L77-L82

If I remember correctly I ported this from the implementation in go. I am not a 100% sure this is still needed in the current version of the implementation, but if you remove it, it should be looked at very carefully that it doesn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dignifiedquire dignifiedquire

Labels
kind/support A question or request for support P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dignifiedquire @daviddias