Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitswap stats #90

Closed
daviddias opened this issue Dec 21, 2016 · 4 comments
Closed

Bitswap stats #90

daviddias opened this issue Dec 21, 2016 · 4 comments
Assignees
@pgte
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP

Comments

@daviddias
Copy link
Member

stats (exchanged byteCount and so on) kind of don't have any self-guards to overflowing

I believe that we should have a way for stats to be disabled and at the same time, make it so they are updated asynchronously, these are just shared values that are mutated with incrementations, which makes it very safe to defer.

Another things is to use a bignum library, otherwise it will get weird in long-running nodes.
@daviddias daviddias added exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue labels Dec 21, 2016
@daviddias daviddias mentioned this issue Dec 21, 2016
Closed
15 tasks
@dignifiedquire
Copy link
Member

I agree with using bignumbers for stats, I don't see any reason why we would want an option to disable them though.

@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Dec 22, 2016
@daviddias daviddias added status/ready Ready to be worked P0 Critical: Tackled by core team ASAP and removed status/deferred Conscious decision to pause or backlog status/ready Ready to be worked labels Oct 17, 2017
@pgte pgte self-assigned this Nov 23, 2017
@daviddias daviddias added status/in-progress In progress and removed status/ready Ready to be worked labels Nov 23, 2017
@pgte
Copy link
Contributor

pgte commented Nov 24, 2017

On this note, to minimize polling, the stats object could be an event emitter, emitting an event when there is a change..

@pgte
Copy link
Contributor

pgte commented Nov 24, 2017

Also, regarding the counters (blocksReceived, dupBlocksReceived and dupDataReceived), I think we could have moving stats (1, 5 15 mins) - average and stddev. What do you say?

@pgte pgte mentioned this issue Nov 26, 2017
Merged
6 tasks
@daviddias
Copy link
Member Author

Done with #158

@ghost ghost removed the status/in-progress In progress label Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgte pgte

Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pgte @dignifiedquire @daviddias