This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: fix electron renderer tests and a couple more bugs #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hugomrdias
commented
Sep 13, 2019
•
hugomrdias
commented
- temp fix for electron renderer until ky-universal is fixed
- Blob can accept Buffer directly
- Buffer.buffer triggered a super weird bug in electron renderer
- enable a bunch of tests in the browser
- xvfb-run makes electron go crazy
- detect-node needs to be removed everywhere and ipfs-utils/src/env.js should be used
- If you mix promises and callbacks inside, call the callback with setImmediate
Buffer.buffer triggered a super weird bug in electron renderer
achingbrain
suggested changes
Sep 13, 2019
hugomrdias
added a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Sep 16, 2019
BREAKING CHANGE: swarm tests need promise based setup check PRs below the following PRs add support async setup: ipfs-inactive/js-ipfs-http-client#1105 ipfs/js-ipfs#2428
hugomrdias
changed the title
hugomrdias
added a commit
that referenced
this pull request
Sep 17, 2019
temp fix for electron renderer until ky-universal is fixed Blob can accept Buffer directly Buffer.buffer triggered a super weird bug in electron renderer enable a bunch of tests in the browser xvfb-run makes electron go crazy detect-node needs to be removed everywhere and ipfs-utils/src/env.js should be used If you mix promises and callbacks inside, call the callback with setImmediate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.