This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Update multiaddr to the latest version 🚀 #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
alanshaw
force-pushed
the
greenkeeper/multiaddr-7.2.0
branch
from
e68019e
to
bc36c8e
Compare
|
Please revert this - we cannot upgrade See: |
|
Shouldn't we fix mafmt to use proto codes not names or where there other issues? |
|
There were problems with dialling peers and likely other stuff but I gave up trying to fix it because it became obvious that there are a lot of moving pieces to change, some of which are already being refactored. Better to wait for libp2p to be upgraded, then upgrade all the IPFS libs. TBH other than appeasing greenkeeper the upgrade itself doesn't give us much. This sort of dependency hell issue would be made more visible by ipfs/js-ipfs#2446 because we'd do the upgrade for this and js-IPFS in one PR, the build for which would fail because libp2p needs upgrading too. |
alanshaw
pushed a commit
that referenced
this pull request
Nov 5, 2019
This reverts commit 9b1589c. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
pushed a commit
that referenced
this pull request
Nov 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency multiaddr was updated from
6.1.1to7.2.0.This version is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
Publisher: jacobheun
License: MIT
Release Notes for v7.2.0
Features
Commits
The new version differs by 13 commits ahead by 13, behind by 3.
4039f38chore: release version v7.2.08d9192bchore: update contributorseead174feat: support Peer ID represented as CID (#102)43cb934docs(fix):fromNodeAddresstake an object (#100)3bcb6d2chore: release version v7.1.0522edfechore: update contributors19a3940feat: add decapsulateCode method (#98)3681086chore: release version v7.0.0e3e93cfchore: update contributors46f257arefactor: default 421 to use p2p by default instead of ipfs (#97)371dc47refactor: use async instead of callbacks (#96)c32071dfix: make getPeerId resolve the last id (#95)2a170c3fix: return ports as ints not strings (#87)See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴