This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
refactor: convert config API to async await #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 12, 2019 21:42
…wait License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
achingbrain
approved these changes
Nov 14, 2019
| expect(err.message).to.eql('boom') | ||
| expect(err.status).to.eql(500) | ||
| expect(err.response.status).to.eql(500) |
There was a problem hiding this comment.
Breaking change? I guess errors aren't really part of the spec other than 'you will get an error'.
There was a problem hiding this comment.
Yes, it is breaking. I've updated the PR description with the info and will include it when merging.
There was a problem hiding this comment.
Great. One small thing - the description says err.status has changed but it's err.statusCode
There was a problem hiding this comment.
Well this test was looking for .status but others are looking for .statusCode...I've added both to the breaking change message.
hugomrdias
approved these changes
Nov 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Errors returned from request failures are now all
HTTPErrors which carry aresponseproperty. This is aResponsethat can be used to inspect all information relating to the HTTP response. This means that theerr.statusorerr.statusCodeproperty should now be accessed viaerr.response.status.