Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Fixed config.replace #634

Merged
merged 3 commits into from
Nov 22, 2017
Merged

Fixed config.replace #634

merged 3 commits into from
Nov 22, 2017

Conversation

pgte
Copy link
Contributor

@pgte pgte commented Nov 22, 2017

, which should now use the new streaming API.
(This wasn't caught on tests because config.replace tests are disabled <= this needs fixing)

Should fix #633.

@ghost ghost assigned pgte Nov 22, 2017
@ghost ghost added the in progress label Nov 22, 2017
@pgte
Copy link
Contributor Author

pgte commented Nov 22, 2017

Broke the build, I think:

job__2494_2_-_ipfs_js-ipfs-api_-_travis_ci

Looking into it..

@ipfs-inactive ipfs-inactive deleted a comment from codecov bot Nov 22, 2017
@pgte pgte requested a review from daviddias November 22, 2017 10:26
@daviddias daviddias merged commit 79d79c5 into master Nov 22, 2017
@daviddias daviddias deleted the fix/config.replace branch November 22, 2017 10:27
@ghost ghost removed the in progress label Nov 22, 2017
@daviddias
Copy link
Contributor

Thank you @pgte :) There you go @hacdias

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@pgte pgte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config.replace stopped working
2 participants
@pgte @daviddias