This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: block.put options #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
alanshaw
force-pushed
the
fix/block-put
branch
from
75672e5
to
0044fa0
Compare
added 3 commits
September 20, 2018 14:44
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
|
Please note that the code has a temporary workaround for ipfs/go-cid#75 |
daviddias
approved these changes
Sep 20, 2018
| } | ||
|
|
||
| const callback = once(_callback) |
There was a problem hiding this comment.
I can't remember but I wonder if this was a protection to go-ipfs sometimes sending multiple errors ?!
There was a problem hiding this comment.
Noted, I guess we'll find out soon ;)
neodon
reviewed
Sep 20, 2018
| // Retry with "protobuf" format for go-ipfs | ||
| // TODO: remove when https://github.com/ipfs/go-cid/issues/75 resolved | ||
| if (qs.format === 'dag-pb') { | ||
| qs.format = 'protobuf' |
There was a problem hiding this comment.
This is the key change for me that would have allowed me to complete #815. Still learned a lot from trying to work that story. Time to find a new issue to dig into. :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #793
Should fix this according to the spec.
fixes #815
closes #793
tested by ipfs-inactive/interface-js-ipfs-core#370(released)