Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Better handling for unexpected responses #912

Closed
alanshaw opened this issue Dec 13, 2018 · 0 comments · Fixed by #1016
Closed

Better handling for unexpected responses #912

alanshaw opened this issue Dec 13, 2018 · 0 comments · Fixed by #1016
Labels
bug difficulty:easy help wanted P1 - High ready

Comments

@alanshaw
Copy link
Contributor

Issues like this will continue to be reported until we can communicate better to the user the cause of the error and/or the response from the server.
@alanshaw alanshaw mentioned this issue Dec 13, 2018
Closed
@alanshaw alanshaw mentioned this issue May 16, 2019
Closed
@KrishnaPG KrishnaPG mentioned this issue May 16, 2019
Closed
@alanshaw alanshaw mentioned this issue May 21, 2019
Merged
alanshaw pushed a commit that referenced this issue May 21, 2019
fix: error reporting for non-JSON responses (#1016)
4251c88 
Better error reporting by detecting `Content-Type` of the response and not attempting to parse JSON for non-`application/json` responses.

resolves #912
resolves #1000
closes #1001

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug difficulty:easy help wanted P1 - High ready
Projects
None yet
Milestone
No milestone
1 participant
@alanshaw