This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat: add support for js-ipfs dag api and also some tests #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
alanshaw
suggested changes
Mar 15, 2019
| expect(result).to.not.exist() | ||
| expect(err.message).to.equal('ipfs-http-client is missing DAG resolver for "raw" multicodec') | ||
| expect(err.message).to.equal('Missing IPLD format "git-raw"') | ||
| done() | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Can these be moved (and deduped) into interface-ipfs-core?
There was a problem hiding this comment.
Sure. This comes up a lot - what's the criteria on deciding where to put them?
There was a problem hiding this comment.
Sorry, I missed this - I mostly view it as a place where we put core tests that are shared between js-ipfs and js-ipfs-http-client.
|
I'm waiting for these tests to pop up again in |
alanshaw
pushed a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Jul 11, 2019
Made by @achingbrain for ipfs-inactive/js-ipfs-http-client#957 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
force-pushed
the
add-js-ipfs-dag-api
branch
from
1fa9ced
to
1a72d9f
Compare
|
@achingbrain I've rebased and added the tests to |
alanshaw
pushed a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Jul 11, 2019
Made by @achingbrain for ipfs-inactive/js-ipfs-http-client#957 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
approved these changes
Jul 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also support for loading raw blocks.