This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Fix support for /https multiaddrs passed to constructor #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned Passing HTTPS multiaddr as a string to constructor did not work, protocol was ignored and unencrypted HTTP was used. This commit improves parsing of multiaddr constructor parameter and adds tests to ensure HTTPS is respected in all scenarios. It also updates iso-stream-http to v0.1.2 which includes fix for "https does not exist" License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
fix/https-multiaddr-support
branch
from
170235b
to
2876d32
Compare
alanshaw
approved these changes
Apr 9, 2019
lidel
added a commit
to ipfs-inactive/ipfs-redux-bundle
that referenced
this pull request
Apr 9, 2019
- updates js-ipfs-http-client to 30.1.2 ipfs-inactive/js-ipfs-http-client#965 - adds tests for implicit http vs explicit https
olizilla
pushed a commit
to ipfs-inactive/ipfs-redux-bundle
that referenced
this pull request
Apr 10, 2019
- updates js-ipfs-http-client to 30.1.2 ipfs-inactive/js-ipfs-http-client#965 - adds tests for implicit http vs explicit https
olizilla
added a commit
to ipfs/ipfs-webui
that referenced
this pull request
Apr 10, 2019
- Update to ipfs-redux-bundle@5.1.1 to get fixes for ipfs-inactive/js-ipfs-http-client#965 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
olizilla
added a commit
to ipfs/ipfs-webui
that referenced
this pull request
Apr 10, 2019
- Update to ipfs-redux-bundle@5.1.1 to get fixes for ipfs-inactive/js-ipfs-http-client#965 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Pointing Web UI at
/httpsmultiaddr did not work: it was not able to connect to API over HTTPS, always tried HTTP (ipfs/ipfs-webui#989):I tracked the bug up to
ipfs-http-clientconstructor: onlyhostandportwere read from multiaddr,protocolwas ignored and unencrypted HTTP was used for all multiaddrs:https://github.com/ipfs/js-ipfs-http-client/blob/21cdcc5100b32e3ac1e75ec70022b9b28b0aede1/src/index.js#L27-L28
Fix
This PR: