Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

fix: replace node buffers with uint8arrays #55

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

achingbrain
Copy link
Member

BREAKING CHANGES:

  • All deps of this module use Uint8Arrays instead of node Buffers

BREAKING CHANGES:

- All deps of this module use Uint8Arrays instead of node Buffers
@jacobheun
Copy link

looks like ci is failing due to webpack bundling issues

@achingbrain
Copy link
Member Author

Hmm, yeah - it was trying to build for the browser, even though this is a node-only module.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vasco-santos vasco-santos merged commit 710a96d into master Aug 14, 2020
@vasco-santos vasco-santos deleted the fix/replace-node-buffers-with-uint8arrays branch August 14, 2020 06:50
@vasco-santos vasco-santos mentioned this pull request Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants