Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPFS Repo fails on node 10.x #167

Closed
jacobheun opened this issue May 9, 2018 · 0 comments · Fixed by #168
Closed

IPFS Repo fails on node 10.x #167

jacobheun opened this issue May 9, 2018 · 0 comments · Fixed by #168
Assignees
@jacobheun
Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@jacobheun
Copy link
Contributor

connects to ipfs/js-ipfs#1347

The version of Level.js being used is failing compilation. This needs to get fixed to resolve node 10 failures in IPFS. Ideally we should move the level.js and leveldown dependencies into the datastore-level codebase to isolate those concerns there.
@jacobheun jacobheun added kind/bug A bug in existing code (including security flaws) exp/wizard Extensive knowledge (implications, ramifications) required P0 Critical: Tackled by core team ASAP status/ready Ready to be worked labels May 9, 2018
@jacobheun jacobheun self-assigned this May 9, 2018
This was referenced May 9, 2018
Merged
Merged
@jacobheun jacobheun added status/in-progress In progress and removed status/ready Ready to be worked labels May 9, 2018
@jacobheun jacobheun mentioned this issue May 9, 2018
Merged
@ghost ghost removed the status/in-progress In progress label May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobheun jacobheun

Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: upgrade datastores for node 10 ipfs/js-ipfs-repo
1 participant
@jacobheun