Skip to content
This repository has been archived by the owner on Aug 12, 2020. It is now read-only.

Using rabin chunker in browser error swallowed? #230

Closed
alanshaw opened this issue Oct 15, 2018 · 2 comments
Closed

Using rabin chunker in browser error swallowed? #230

alanshaw opened this issue Oct 15, 2018 · 2 comments

Comments

@alanshaw
Copy link
Contributor

Error should be being thrown:
https://github.com/ipfs/js-ipfs-unixfs-engine/blob/master/src/chunker/rabin.js#L9-L15

...but attempting to use in browser doesn't appear to cause an error ipfs/js-ipfs#1633

@achingbrain
Copy link
Collaborator

I've updated the code to return a pull-through transform stream that errors instead of throwing, should be a bit nicer to work with.

@achingbrain
Copy link
Collaborator

N.b. I can't release this yet because interface-datastore has been updated so this instanceof check fails. Once js-ipfs has interface-datastore@0.0.6 it should start working again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants