fix(core): consistent repo.exists checks

package.json

@@ -68,7 +68,7 @@
     "ipfs-data-importing": "^0.3.3",
     "ipfs-merkle-dag": "^0.5.0",
     "ipfs-multipart": "^0.1.0",
-    "ipfs-repo": "^0.7.1",
+    "ipfs-repo": "^0.8.0",
     "joi": "^8.0.2",
     "libp2p-ipfs": "^0.3.3",
     "lodash.get": "^4.2.1",

src/core/index.js

@@ -1,6 +1,5 @@
 'use strict'
 
-const defaultRepo = require('./default-repo')
 const BlockService = require('ipfs-block-service')
 const Block = require('ipfs-block')
 const mDAG = require('ipfs-merkle-dag')
@@ -11,10 +10,13 @@ const PeerInfo = require('peer-info')
 const multiaddr = require('multiaddr')
 const importer = require('ipfs-data-importing').import
 const libp2p = require('libp2p-ipfs')
-const init = require('./init')
 const IPFSRepo = require('ipfs-repo')
 const PeerBook = require('peer-book')
 
+const init = require('./init')
+const defaultRepo = require('./default-repo')
+const utils = require('./utils')
+
 exports = module.exports = IPFS
 
 function IPFS (repo) {
@@ -33,7 +35,7 @@ function IPFS (repo) {
   const peerInfoBook = new PeerBook()
 
   this.load = (callback) => {
-    repo.exists((err, exists) => {
+    utils.ifRepoExists(repo, (err) => {
       if (err) {
         throw err
       }
@@ -58,11 +60,15 @@ function IPFS (repo) {
       opts = {}
     }
 
-    repo.exists((err, exists) => {
-      if (err) { return callback(err) }
+    utils.ifRepoExists(repo, (err) => {
+      if (err) {
+        return callback(err)
+      }
 
       repo.config.get((err, config) => {
-        if (err) { return callback(err) }
+        if (err) {
+          return callback(err)
+        }
 
         callback(null, config.Version.Current)
       })
@@ -100,8 +106,12 @@ function IPFS (repo) {
         callback = opts
         opts = {}
       }
-      repo.exists((err, res) => {
-        if (err) { return callback(err) }
+
+      utils.ifRepoExists(repo, (err, res) => {
+        if (err) {
+          return callback(err)
+        }
+
         repo.version.get(callback)
       })
     },

src/core/init.js

@@ -14,9 +14,12 @@ module.exports = (repo, opts, callback) => {
   var config = require('../init-files/default-config.json')
 
   // Verify repo does not yet exist.
-  repo.exists((err, res) => {
-    if (err) { return callback(err) }
-    if (res === true) {
+  repo.exists((err, exists) => {
+    if (err) {
+      return callback(err)
+    }
+
+    if (exists === true) {
       return callback(new Error('repo already exists'))
     }
 

src/core/utils.js

@@ -0,0 +1,15 @@
+'use strict'
+
+exports.ifRepoExists = (repo, cb) => {
+  repo.exists((err, exists) => {
+    if (err) {
+      return cb(err)
+    }
+
+    if (exists === false) {
+      return cb(new Error('no ipfs repo found'))
+    }
+
+    cb()
+  })
+}