-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
Other modules we depend on also depend on lodash. We actually save around 100KB on bundle size if we use lodash like we use async (require functions we need from the main package) since the functions we require can be deduped because they're already being depended on. License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
All in for this change! 🚀 |
I will change those for:
|
Other modules that IPFS are in charge of that are using individual lodash modules that would help our bundle size if they switched:
|
All maintainers should aim to keep these types of requires consistent. |
also consider native methods if they can be used in the repo context. |
Maybe we should create a endeavour listing everything. What do you think? Meanwhile, I created a PR also for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super interesting. Thought these would be the same.
Other modules we depend on also depend on lodash.
We actually save around 100KB on bundle size if we use lodash like we use async (require functions we need from the main package) since the functions we require can be deduped because they're already being depended on.