This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: adds data-encoding argument to control data encoding #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
alanshaw
changed the title
|
This requires go-ipfs 0.4.17 to be released first - not much point merging this until then. |
achingbrain
force-pushed
the
allow-overriding-data-encoding
branch
from
6f9a061
to
1e7b1fe
Compare
achingbrain
force-pushed
the
allow-overriding-data-encoding
branch
2 times, most recently
from
a9eaa03
to
dd1e57e
Compare
|
@achingbrain this will need the fixes in #1508 before it'll pass CI |
achingbrain
force-pushed
the
allow-overriding-data-encoding
branch
2 times, most recently
from
f5d6906
to
fecc22f
Compare
Allows the user to specify how object data is returned to prevent default byte encoding from emitting characters that are not valid in JSON.
achingbrain
force-pushed
the
allow-overriding-data-encoding
branch
from
22e76c0
to
2daf20a
Compare
alanshaw
changed the title
alanshaw
approved these changes
Aug 17, 2018
|
I was beginning to think CI would never pass. Quick, merge it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the js counterpart to ipfs/kubo#5139 and will allow the test in ipfs-inactive/interface-js-ipfs-core#302 to pass.
ipfs-inactive/js-ipfs-http-client#806 needs this to be merged before the interface test linked to above will pass.