Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: enable tests in node that were not being included #1499

Merged
merged 2 commits into from
Sep 14, 2018

Conversation

alanshaw
Copy link
Member

@vasco-santos uses npm run test:node:core which runs tests in test/core/**/*.js and there were some tests failing.

CI runs npm test => npm test:node => which runs only mocha test/node.js.

...which requires only:

require('./cli')
require('./http-api')
require('./gateway')
require('./core/node.js')

and core/node.js requires only

require('./pin')
require('./pin-set')

NOT utils.js and others!!!

Lets see if they pass.

@ghost ghost assigned alanshaw Aug 10, 2018
@ghost ghost added the status/in-progress In progress label Aug 10, 2018
@alanshaw alanshaw force-pushed the fix/enable-missing-node-tests branch from fc92aac to 2095dda Compare August 15, 2018 15:46
@ghost ghost assigned vasco-santos Aug 28, 2018
@vasco-santos
Copy link
Member

vasco-santos commented Aug 28, 2018

Hey @alanshaw , thanks for this PR.

Enabling the utils test lead to failling the resolvePath test.

I added a commit fixing those 2 tests. Basically:

objectAPI.get(rootHash, ...)

get was receiving as the first parameter the instance of the cid instead of its multihash.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

alanshaw and others added 2 commits September 13, 2018 15:38
@alanshaw alanshaw merged commit 2585431 into master Sep 14, 2018
@alanshaw alanshaw deleted the fix/enable-missing-node-tests branch September 14, 2018 15:27
@ghost ghost removed the status/in-progress In progress label Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants