This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
perf: faster startup #1528
Merged
perf: faster startup #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
ghost
assigned 
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI daemon on (over HTTP API)
Command:
ipfs cat QmfM2r8seH2GiRaC4esTjeraXEachRt8ZsSeGaWTPLyMoGFor talking to the daemon over the HTTP API there should be no need to
requireIPFS core.I noticed that the CLI
daemoncommand required the HTTP API, which requiresHapi, and IPFS core itself. Similarly, theinitcommand also requires IPFS core itself.Moving these requires inline avoids this.
Before (> 1200ms total):
After (< 600ms total):