This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: add support to pass config in the init cmd #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomrdias
requested review from
alanshaw,
achingbrain,
daviddias and
vasco-santos
ghost
assigned
1 task
daviddias
force-pushed
the
feat/init-config
branch
from
5b8b8d6
to
3079370
Compare
|
@alanshaw can we get this one in the upcoming release? |
alanshaw
suggested changes
Oct 29, 2018
There was a problem hiding this comment.
Awesome @hugomrdias - just one question, everything else LGTM
src/core/components/init.js
Outdated
| @@ -4,6 +4,7 @@ const peerId = require('peer-id') | |||
| const waterfall = require('async/waterfall') | |||
| const parallel = require('async/parallel') | |||
| const promisify = require('promisify-es6') | |||
| const extend = require('deep-extend') | |||
There was a problem hiding this comment.
Are we able to use @nodeutils/defaults-deep here? It's a missing dependency that we decided not to add here #1663 in favour of @nodeutils/defaults-deep.
hugomrdias
force-pushed
the
feat/init-config
branch
from
3079370
to
ca7677d
Compare
|
@alanshaw swap deep-extend with defaults-deep with last commit |
alanshaw
approved these changes
Oct 29, 2018
|
Just waiting for CI |
|
|
|
🎉🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to pass node config in the init cmd. The main purpose for this is to improve the speed of ipfsd-ctl and all the tests that use ctl.
example:
ipfs init '{"Addresses":{"Swarm":["/ip4/0.0.0.0/tcp/4003"]}}'This merges the input config with the default config, just like the node api already does.
Check ipfsd-ctl PR related to this one for speed improvements ipfs/js-ipfsd-ctl#303
Right now we need to spawn 4 child_processes to start a node in ctl
With this PR we would only need 2
And with further changes we could do
ipfs daemon --init --config "{}"Right now i think we have a couple of problems with this
Questions:
ipfs config merge?Go version works like this https://docs.ipfs.io/reference/api/cli/#ipfs-init