Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Prevent mfs corruption #1743

Closed
achingbrain opened this issue Dec 2, 2018 · 4 comments
Closed

Prevent mfs corruption #1743

achingbrain opened this issue Dec 2, 2018 · 4 comments
Assignees
Labels
exp/expert Having worked on the specific codebase is important kind/resolved-in-helia P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@achingbrain
Copy link
Member

I think we need a mechanism for js-ipfs components to prevent the process from exiting until they've finished a bit of critical work (could show a CTRL-C to force quit kind of message).

My concern is that if mfs is interrupted while writing the root hash to the level datastore, it'll potentially not be able to read the hash on the next startup which would show the user an empty directory.

@alanshaw
Copy link
Member

alanshaw commented Dec 2, 2018

Received interrupt signal, shutting down...
(Hit ctrl-c again to force-shutdown the daemon.)

Like go-ipfs?

@alanshaw alanshaw added exp/expert Having worked on the specific codebase is important status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Dec 4, 2018
@grantlouisherman
Copy link
Contributor

Hey @alanshaw could I take this one?

@alanshaw
Copy link
Member

@grantlouisherman you are welcome to have a go at this, but the issues labelled "help wanted" might be slightly more appropriate for new contributors https://github.com/ipfs/js-ipfs/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22

In particular I'd love to see #1867 implemented.

@SgtPooki SgtPooki self-assigned this May 17, 2023
@SgtPooki SgtPooki moved this to 🥞 Todo in js-ipfs deprecation May 17, 2023
@SgtPooki
Copy link
Member

js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide.

Please feel to reopen with any comments by 2023-06-02. We will do a final pass on reopened issues afterwards (see #4336).

This issue is most likely resolved in Helia, please try it out!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/expert Having worked on the specific codebase is important kind/resolved-in-helia P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants