This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: print valid ipv6 multiaddrs in terminal #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@lidel would you mind rebasing this now the Hapi 18 refactor has been merged? |
|
ping @lidel |
Fixes #1853 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
fix/ipv6-in-stdout
branch
from
95cc1c2
to
83f0129
Compare
|
@alanshaw rebased :) |
alanshaw
suggested changes
Feb 11, 2019
| let uri = info.uri | ||
| // ipv6 fix | ||
| if (hostname.includes(':') && !hostname.startsWith('[')) { | ||
| // hapi 16 produces invalid URI for ipv6 |
There was a problem hiding this comment.
Is this still needed? We use hapi 18 now...
There was a problem hiding this comment.
Sadly still needed: I tried with vanilla hapi 18 and uri inside of apiServer.info was still broken (missing brackets), which produced broken ma:
{
"created": 1549909555055,
"started": 1549909555222,
"host": "::1",
"port": 5002,
"protocol": "http",
"id": "foo:5989:js0o4qjz",
"uri": "http://::1:5002",
"address": "::1",
"ma": "/ip4//tcp/"
}Due to this the line should stay :)
Suggested change
| // hapi 16 produces invalid URI for ipv6 | |
| // hapi 18 produces invalid URI for ipv6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1853
(easy enough to do it as a drive-by, let me know if I should rebase this after #1844 is merged)
Before:
After: