Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

ipfs name resolve with recursive default to true makes name-pubsub fail #2001

Closed
hugomrdias opened this issue Apr 18, 2019 · 0 comments
Closed

ipfs name resolve with recursive default to true makes name-pubsub fail #2001

hugomrdias opened this issue Apr 18, 2019 · 0 comments
Labels
exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@hugomrdias
Copy link
Member

hugomrdias commented Apr 18, 2019 •
edited
Loading

  • Version:master
  • Platform:all
  • Subsystem:name

Type:Bug

Severity: High

Description:

go-ipfs changed the default value for the recursive option in ipfs name resolve, so we should do the same.

But in js-ipfs name-pubsub tests fail, with recursive === true.

Steps to reproduce the error:

default to true in these places:
https://github.com/ipfs/js-ipfs/blob/master/src/cli/commands/name/resolve.js#L21
https://github.com/ipfs/js-ipfs/blob/master/src/http/api/resources/name.js#L10
https://github.com/ipfs/js-ipfs/blob/master/src/core/components/name.js#L130

/cc @vasco-santos
@hugomrdias hugomrdias added kind/bug A bug in existing code (including security flaws) exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up labels Apr 18, 2019
This was referenced Apr 18, 2019
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hugomrdias