Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

[optimization] Use individual methods of async #214

Closed
3 of 4 tasks
dignifiedquire opened this issue May 11, 2016 · 9 comments
Closed
3 of 4 tasks

[optimization] Use individual methods of async #214

dignifiedquire opened this issue May 11, 2016 · 9 comments
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue

Comments

@dignifiedquire
Copy link
Member

dignifiedquire commented May 11, 2016

Known culprits:

@dignifiedquire dignifiedquire added enhancement exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue labels May 11, 2016
@daviddias daviddias changed the title [optimization] No more async in the browser build [optimization] No more async in the browser build Jul 27, 2016
@dignifiedquire dignifiedquire changed the title [optimization] No more async in the browser build [optimization] No more async in the browser build Aug 1, 2016
@daviddias daviddias changed the title [optimization] No more async in the browser build [optimization] No more async in the browser build Aug 13, 2016
@daviddias
Copy link
Member

When I read the title of this issue again my reaction was, "wait, no more async calls?" :D

async is now modular, not sure if this is an optimization/concern anymore

@dignifiedquire
Copy link
Member Author

That is correct, we can now migrate the rest of the modules that use async to use the modular 2.0 version.

@daviddias
Copy link
Member

Awesome :) Closing this one, as that is just a 'dep update', it will happen with following releases, naturally.

@dignifiedquire
Copy link
Member Author

Sorry, but it's more than that, we have to specifically change our code to use the form of

const each = require('async/each')

to actually get the benefits of this.

@dignifiedquire dignifiedquire changed the title [optimization] No more async in the browser build [optimization] Use individual methods of async Aug 15, 2016
@dignifiedquire dignifiedquire added exp/novice Someone with a little familiarity can pick up and removed exp/expert Having worked on the specific codebase is important labels Aug 15, 2016
@daviddias
Copy link
Member

Ok. Can you list out all the cases where async happens (+ run-*) so that we make sure to tackle all of them? Thank you

@dignifiedquire
Copy link
Member Author

I'm pretty sure that's nearly every single repo of libp2p/js-* and ipfs/js-*

@nginnever
Copy link
Member

nginnever commented Aug 17, 2016

async crawl >.<

actually not that many modules depend on async anymore

  • js-ipfs-api PR
  • js-ipfs-repo (dev only) PR
  • js-libp2p-kad-routing PR
  • js-ipfs-unixfs-engine (dev only) PR

I have set up an example pr, if it looks good i'll iterate over the rest.

Do we care to update this if async is only a dev dep? adding them to the list for now.

@dignifiedquire
Copy link
Member Author

I think we should do it for dev as well, as that means the bundles in the test runs are smaller, making it a bit faster :)

@daviddias
Copy link
Member

Seems that this has been taken care of with exception of bitswap which has its own issue ipfs/js-ipfs-bitswap#14. Closing this one, reopen if needed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue
Projects
None yet
Development

No branches or pull requests

3 participants